Add source column to chrome://policy showing the origins of policies.

components/policy/core/common/async_policy_provider_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/async_policy_provider.h"
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/sequenced_task_runner.h"
@@ skipping 18 matching lines @@
                const std::string& name,
                const std::string& value) {
   bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
       .Set(name,
            POLICY_LEVEL_MANDATORY,
            POLICY_SCOPE_USER,
            new base::StringValue(value),
            NULL);
 }
 
+void SetPlatformPolicy(PolicyBundle* bundle,

[Thiemo Nagel, 2015/09/04 20:15:53]

Is it really necessary to have a separate function?  Why not change the existing
one?

[fhorschig, 2015/09/07 14:09:34]

No. Removed.

+                       const std::string& name,
+                       const std::string& value) {
+  bundle->Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
+      .SetWithSource(name,
+                     POLICY_LEVEL_MANDATORY,
+                     POLICY_SCOPE_USER,
+                     new base::StringValue(value),
+                     NULL,
+                     POLICY_SOURCE_PLATFORM);
+}
+
 class MockPolicyLoader : public AsyncPolicyLoader {
  public:
   explicit MockPolicyLoader(
       scoped_refptr<base::SequencedTaskRunner> task_runner);
   ~MockPolicyLoader() override;
 
   // Load() returns a scoped_ptr<PolicyBundle> but it can't be mocked because
   // scoped_ptr is moveable but not copyable. This override forwards the
   // call to MockLoad() which returns a PolicyBundle*, and returns a copy
   // wrapped in a passed scoped_ptr.
@@ skipping 71 matching lines @@
 void AsyncPolicyProviderTest::TearDown() {
   if (provider_) {
     provider_->Shutdown();
     provider_.reset();
   }
   loop_.RunUntilIdle();
 }
 
 TEST_F(AsyncPolicyProviderTest, RefreshPolicies) {
   PolicyBundle refreshed_bundle;
-  SetPolicy(&refreshed_bundle, "policy", "refreshed");
+  SetPlatformPolicy(&refreshed_bundle, "policy", "refreshed");
   EXPECT_CALL(*loader_, MockLoad()).WillOnce(Return(&refreshed_bundle));
 
   MockConfigurationPolicyObserver observer;
   provider_->AddObserver(&observer);
   EXPECT_CALL(observer, OnUpdatePolicy(provider_.get())).Times(1);
   provider_->RefreshPolicies();
   loop_.RunUntilIdle();
   // The refreshed policies are now provided.
   EXPECT_TRUE(provider_->policies().Equals(refreshed_bundle));
   provider_->RemoveObserver(&observer);
 }
 
 TEST_F(AsyncPolicyProviderTest, RefreshPoliciesTwice) {
   PolicyBundle refreshed_bundle;
-  SetPolicy(&refreshed_bundle, "policy", "refreshed");
+  SetPlatformPolicy(&refreshed_bundle, "policy", "refreshed");
   EXPECT_CALL(*loader_, MockLoad()).WillRepeatedly(Return(&refreshed_bundle));
 
   MockConfigurationPolicyObserver observer;
   provider_->AddObserver(&observer);
   EXPECT_CALL(observer, OnUpdatePolicy(provider_.get())).Times(0);
   provider_->RefreshPolicies();
   // Doesn't refresh before going through the background thread.
   Mock::VerifyAndClearExpectations(&observer);
 
   // Doesn't refresh if another RefreshPolicies request is made.
   EXPECT_CALL(observer, OnUpdatePolicy(provider_.get())).Times(0);
   provider_->RefreshPolicies();
   Mock::VerifyAndClearExpectations(&observer);
 
   EXPECT_CALL(observer, OnUpdatePolicy(provider_.get())).Times(1);
   loop_.RunUntilIdle();
   // The refreshed policies are now provided.
   EXPECT_TRUE(provider_->policies().Equals(refreshed_bundle));
   Mock::VerifyAndClearExpectations(&observer);
   provider_->RemoveObserver(&observer);
 }
 
 TEST_F(AsyncPolicyProviderTest, RefreshPoliciesDuringReload) {
   PolicyBundle reloaded_bundle;
-  SetPolicy(&reloaded_bundle, "policy", "reloaded");
+  SetPlatformPolicy(&reloaded_bundle, "policy", "reloaded");
   PolicyBundle refreshed_bundle;
-  SetPolicy(&refreshed_bundle, "policy", "refreshed");
+  SetPlatformPolicy(&refreshed_bundle, "policy", "refreshed");
 
   Sequence load_sequence;
   // Reload.
   EXPECT_CALL(*loader_, MockLoad()).InSequence(load_sequence)
                                    .WillOnce(Return(&reloaded_bundle));
   // RefreshPolicies.
   EXPECT_CALL(*loader_, MockLoad()).InSequence(load_sequence)
                                    .WillOnce(Return(&refreshed_bundle));
 
   MockConfigurationPolicyObserver observer;
@@ skipping 34 matching lines @@
   EXPECT_CALL(observer, OnUpdatePolicy(provider_.get())).Times(0);
   provider_->Shutdown();
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer);
 
   provider_->RemoveObserver(&observer);
   provider_.reset();
 }
 
 }  // namespace policy