Add source column to chrome://policy showing the origins of policies.

chrome/browser/ui/webui/policy_ui_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_reader.h"
 #include "base/run_loop.h"
@@ skipping 44 matching lines @@
   }
 
   // Populate expected level.
   if (metadata) {
     expected_policy.push_back(l10n_util::GetStringUTF8(
         metadata->level == policy::POLICY_LEVEL_RECOMMENDED ?
             IDS_POLICY_LEVEL_RECOMMENDED : IDS_POLICY_LEVEL_MANDATORY));
   } else {
     expected_policy.push_back(std::string());
   }
+  // Populate expected source name.
+  // TODO(fhorschig): Make MockProvider use another source.
+  expected_policy.push_back(std::string());  // MockProvider sets to unknown.
 
   // Populate expected policy name.
   expected_policy.push_back(name);
 
   // Populate expected policy value.
   expected_policy.push_back(value);
 
+

[Thiemo Nagel, 2015/09/04 20:15:53]

Remove blank line.

[fhorschig, 2015/09/07 14:09:33]

Done.

   // Populate expected status.
   if (unknown)
     expected_policy.push_back(l10n_util::GetStringUTF8(IDS_POLICY_UNKNOWN));
   else if (metadata)
     expected_policy.push_back(l10n_util::GetStringUTF8(IDS_POLICY_OK));
   else
     expected_policy.push_back(l10n_util::GetStringUTF8(IDS_POLICY_UNSET));
 
   // Populate expected expanded policy value.
   expected_policy.push_back(value);
@@ skipping 29 matching lines @@
 PolicyUITest::~PolicyUITest() {
 }
 
 void PolicyUITest::SetUpInProcessBrowserTestFixture() {
   EXPECT_CALL(provider_, IsInitializationComplete(_))
       .WillRepeatedly(Return(true));
   policy::BrowserPolicyConnector::SetPolicyProviderForTesting(&provider_);
 }
 
 void PolicyUITest::UpdateProviderPolicy(const policy::PolicyMap& policy) {
- provider_.UpdateChromePolicy(policy);
- base::RunLoop loop;
- loop.RunUntilIdle();
+  provider_.UpdateChromePolicy(policy);
+  base::RunLoop loop;
+  loop.RunUntilIdle();
 }
 
 void PolicyUITest::VerifyPolicies(
     const std::vector<std::vector<std::string> >& expected_policies) {
   ui_test_utils::NavigateToURL(browser(), GURL("chrome://policy"));
 
   // Retrieve the text contents of the policy table cells for all policies.
   const std::string javascript =
       "var entries = document.querySelectorAll("
       "    'section.policy-table-section > * > tbody');"
@@ skipping 45 matching lines @@
   // the correct order.
 
   // Expect that the policy table contains all known policies in alphabetical
   // order and none of the policies have a set value.
   std::vector<std::vector<std::string> > expected_policies;
   policy::Schema chrome_schema =
       policy::Schema::Wrap(policy::GetChromeSchemaData());
   ASSERT_TRUE(chrome_schema.valid());
   for (policy::Schema::Iterator it = chrome_schema.GetPropertiesIterator();
        !it.IsAtEnd(); it.Advance()) {
-    expected_policies.push_back(
-        PopulateExpectedPolicy(it.key(), std::string(), NULL, false));
+    expected_policies.push_back(PopulateExpectedPolicy(

[Thiemo Nagel, 2015/09/04 20:15:53]

Don't reformat!

[fhorschig, 2015/09/07 14:09:34]

Done.

+        it.key(), std::string(), NULL, false));
   }
 
   // Retrieve the contents of the policy table from the UI and verify that it
   // matches the expectation.
   VerifyPolicies(expected_policies);
 }
 
 IN_PROC_BROWSER_TEST_F(PolicyUITest, SendPolicyValues) {
   // Verifies that policy values are sent to the UI and processed there
   // correctly by setting the values of four known and one unknown policy and
@@ skipping 11 matching lines @@
              policy::POLICY_LEVEL_MANDATORY,
              policy::POLICY_SCOPE_USER,
              restore_on_startup_urls,
              NULL);
   expected_values[policy::key::kRestoreOnStartupURLs] = "aaa,bbb,ccc";
   values.Set(policy::key::kHomepageLocation,
              policy::POLICY_LEVEL_MANDATORY,
              policy::POLICY_SCOPE_MACHINE,
              new base::StringValue("http://google.com"),
              NULL);
+

[Thiemo Nagel, 2015/09/04 20:15:53]

Remove blank line.

[fhorschig, 2015/09/07 14:09:34]

Done.

   expected_values[policy::key::kHomepageLocation] = "http://google.com";
   values.Set(policy::key::kRestoreOnStartup,
              policy::POLICY_LEVEL_RECOMMENDED,
              policy::POLICY_SCOPE_USER,
              new base::FundamentalValue(4),
              NULL);
   expected_values[policy::key::kRestoreOnStartup] = "4";
   values.Set(policy::key::kShowHomeButton,
              policy::POLICY_LEVEL_RECOMMENDED,
              policy::POLICY_SCOPE_MACHINE,
@@ skipping 78 matching lines @@
   service->OnExtensionInstalled(builder.Build().get(), syncer::StringOrdinal(),
                                 0);
 
   std::vector<std::vector<std::string>> expected_policies;
   policy::Schema chrome_schema =
       policy::Schema::Wrap(policy::GetChromeSchemaData());
   ASSERT_TRUE(chrome_schema.valid());
 
   for (policy::Schema::Iterator it = chrome_schema.GetPropertiesIterator();
        !it.IsAtEnd(); it.Advance()) {
-    expected_policies.push_back(
-        PopulateExpectedPolicy(it.key(), std::string(), NULL, false));
+    expected_policies.push_back(PopulateExpectedPolicy(

[Thiemo Nagel, 2015/09/04 20:15:53]

Don't reformat.

[fhorschig, 2015/09/07 14:09:33]

Done.

+        it.key(), std::string(), NULL, false));
   }
   // Add newly added policy to expected policy list.
   expected_policies.push_back(PopulateExpectedPolicy(
       newly_added_policy_name, std::string(), NULL, false));
 
   // Verify if policy UI includes policy that extension have.
   VerifyPolicies(expected_policies);
 }