Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1304833003: Update chrome:// page favicons (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 3 months ago
Reviewers:
oshima, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update chrome:// page favicons Unfortunately, these can't be vectorized easily because blink and Chrome don't support SVG favicons. BUG=505953 TBR=oshima@chromium.org Committed: https://crrev.com/a057486bc10ddb8e82483f3ac1936a72615e9e62 Cr-Commit-Position: refs/heads/master@{#345949}

Patch Set 1 #

Patch Set 2 : also default favicon #

Patch Set 3 : also defaults #

Patch Set 4 : fix flags #

Patch Set 5 : rebase #

Patch Set 6 : no update to legacy phone icon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/app/theme/default_100_percent/common/favicon_bookmarks.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_conflicts.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_downloads.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_extensions.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_flags.png View 1 2 3 Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_history.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_print_preview.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_sad_tab.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/favicon_settings.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_bookmarks.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_conflicts.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_downloads.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_extensions.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_flags.png View 1 2 3 Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_history.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_print_preview.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_sad_tab.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/favicon_settings.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/default_favicon.png View 1 Binary file 0 comments Download
M ui/resources/default_200_percent/common/default_favicon.png View 1 Binary file 0 comments Download

Messages

Total messages: 17 (7 generated)
Evan Stade
5 years, 4 months ago (2015-08-25 16:46:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304833003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304833003/60001
5 years, 4 months ago (2015-08-25 17:12:35 UTC) #4
Dan Beam
lgtm
5 years, 4 months ago (2015-08-25 17:22:54 UTC) #5
Evan Stade
On 2015/08/25 17:22:54, Dan Beam wrote: > lgtm note that the default_favicon looks a bit ...
5 years, 4 months ago (2015-08-25 17:27:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-25 19:00:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304833003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304833003/60001
5 years, 4 months ago (2015-08-25 19:59:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/92592)
5 years, 4 months ago (2015-08-25 20:10:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304833003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304833003/100001
5 years, 3 months ago (2015-08-27 18:18:40 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-08-27 19:35:05 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 19:35:45 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a057486bc10ddb8e82483f3ac1936a72615e9e62
Cr-Commit-Position: refs/heads/master@{#345949}

Powered by Google App Engine
This is Rietveld 408576698