Issue 130483006: Revert "TimelinePanel: introduce StackView and use it instead of _timelineMemorySplitter"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130483006: Revert "TimelinePanel: introduce StackView and use it instead of _timelineMemorySplitter" (Closed)

Created:
6 years, 11 months ago by loislo

Modified:
6 years, 11 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "TimelinePanel: introduce StackView and use it instead of _timelineMemorySplitter" This reverts commit b5c27b516609da2e9fa13187f6eb2a31e50f529c. BUG= TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165128

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -135 lines)			Patch
M	Source/devtools/devtools.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/devtools/front_end/StackView.js	View	1 chunk	+0 lines, -66 lines	0 comments	Download
M	Source/devtools/front_end/TimelineView.js	View	8 chunks	+73 lines, -64 lines	0 comments	Download
M	Source/devtools/front_end/inspector.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

loislo

6 years, 11 months ago (2014-01-15 14:23:29 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r165128 (presubmit successful).

Expand Messages | Collapse Messages