Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: runtime/vm/instructions_arm64.h

Issue 1304743003: VM: Remove dead code from arm/mips/arm64 call instruction patterns (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed feedback from previous CL Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/instructions_arm.cc ('k') | runtime/vm/instructions_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Classes that describe assembly patterns as used by inline caches. 4 // Classes that describe assembly patterns as used by inline caches.
5 5
6 #ifndef VM_INSTRUCTIONS_ARM64_H_ 6 #ifndef VM_INSTRUCTIONS_ARM64_H_
7 #define VM_INSTRUCTIONS_ARM64_H_ 7 #define VM_INSTRUCTIONS_ARM64_H_
8 8
9 #ifndef VM_INSTRUCTIONS_H_ 9 #ifndef VM_INSTRUCTIONS_H_
10 #error Do not include instructions_arm64.h directly; use instructions.h instead. 10 #error Do not include instructions_arm64.h directly; use instructions.h instead.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 static intptr_t OffsetFromPPIndex(intptr_t index); 53 static intptr_t OffsetFromPPIndex(intptr_t index);
54 }; 54 };
55 55
56 56
57 class CallPattern : public ValueObject { 57 class CallPattern : public ValueObject {
58 public: 58 public:
59 CallPattern(uword pc, const Code& code); 59 CallPattern(uword pc, const Code& code);
60 60
61 RawICData* IcData(); 61 RawICData* IcData();
62 RawArray* ClosureArgumentsDescriptor();
63 62
64 uword TargetAddress() const; 63 uword TargetAddress() const;
65 void SetTargetAddress(uword target_address) const; 64 void SetTargetAddress(uword target_address) const;
66 65
67 // This constant length is only valid for inserted call patterns used for 66 // This constant length is only valid for inserted call patterns used for
68 // lazy deoptimization. Regular call pattern may vary in length. 67 // lazy deoptimization. Regular call pattern may vary in length.
69 static const int kLengthInBytes = 5 * Instr::kInstrSize; 68 static const int kLengthInBytes = 5 * Instr::kInstrSize;
70 69
71 static void InsertAt(uword pc, uword target_address); 70 static void InsertAt(uword pc, uword target_address);
72 71
73 private: 72 private:
74 const ObjectPool& object_pool_; 73 const ObjectPool& object_pool_;
75 74
76 uword end_; 75 uword end_;
77 uword args_desc_load_end_;
78 uword ic_data_load_end_; 76 uword ic_data_load_end_;
79 77
80 intptr_t target_address_pool_index_; 78 intptr_t target_address_pool_index_;
81 Array& args_desc_;
82 ICData& ic_data_; 79 ICData& ic_data_;
83 80
84 DISALLOW_COPY_AND_ASSIGN(CallPattern); 81 DISALLOW_COPY_AND_ASSIGN(CallPattern);
85 }; 82 };
86 83
87 84
88 class JumpPattern : public ValueObject { 85 class JumpPattern : public ValueObject {
89 public: 86 public:
90 JumpPattern(uword pc, const Code& code); 87 JumpPattern(uword pc, const Code& code);
91 88
(...skipping 27 matching lines...) Expand all
119 116
120 bool IsValid() const; 117 bool IsValid() const;
121 118
122 private: 119 private:
123 const uword pc_; 120 const uword pc_;
124 }; 121 };
125 122
126 } // namespace dart 123 } // namespace dart
127 124
128 #endif // VM_INSTRUCTIONS_ARM64_H_ 125 #endif // VM_INSTRUCTIONS_ARM64_H_
OLDNEW
« no previous file with comments | « runtime/vm/instructions_arm.cc ('k') | runtime/vm/instructions_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698