Issue 130473002: [GCM] Make GCM API not work in incognito mode

Issue 130473002: [GCM] Make GCM API not work in incognito mode (Closed)

Created:
6 years, 11 months ago by jianli

Modified:
6 years, 11 months ago

Reviewers:
fgorski

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[GCM] Make GCM API not work in incognito mode BUG=284553 TEST=new tests added Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244085

Patch Set 2 : Address comments #

Patch Set 3 : Patch to land #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -17 lines)			Patch
M	chrome/browser/extensions/api/gcm/gcm_api.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/gcm/gcm_apitest.cc	View	1 2	2 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/services/gcm/gcm_profile_service.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/services/gcm/gcm_profile_service.cc	View	1	8 chunks	+34 lines, -5 lines	0 comments	Download
M	chrome/browser/services/gcm/gcm_profile_service_factory.cc	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/services/gcm/gcm_profile_service_unittest.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/gcm/functions/incognito/manifest.json	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	chrome/test/data/extensions/api_test/gcm/functions/incognito/test.js	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

fgorski

LGTM with nits. https://codereview.chromium.org/130473002/diff/1/chrome/browser/services/gcm/gcm_profile_service.cc File chrome/browser/services/gcm/gcm_profile_service.cc (right): https://codereview.chromium.org/130473002/diff/1/chrome/browser/services/gcm/gcm_profile_service.cc#newcode41 chrome/browser/services/gcm/gcm_profile_service.cc:41: // Adds an app to the ...

6 years, 11 months ago (2014-01-09 22:06:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/130473002/380001

6 years, 11 months ago (2014-01-10 01:14:53 UTC) #3

Message was sent while issue was closed.

Change committed as 244085

Expand Messages | Collapse Messages