Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 13047009: [Android] Fix a race condition in run_command.py. (Closed)

Created:
7 years, 9 months ago by craigdh
Modified:
7 years, 9 months ago
Reviewers:
frankf
CC:
chromium-reviews
Visibility:
Public.

Description

[Android] Fix a race condition in run_command.py. This patch makes limited changes to minimize the likelyhood of breaking dependent scripts. NOTRY=True TBR=brettw@chromium.org BUG=180587 TEST=ran run_command.RunOnce with a timeout of 0. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -36 lines) Patch
M third_party/android_testrunner/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/android_testrunner/patch.diff View 1 chunk +87 lines, -0 lines 0 comments Download
M third_party/android_testrunner/run_command.py View 2 chunks +25 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
craigdh
7 years, 9 months ago (2013-03-25 21:28:49 UTC) #1
frankf
lgtm after trybots pass
7 years, 9 months ago (2013-03-25 21:41:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/13047009/1
7 years, 9 months ago (2013-03-25 23:31:00 UTC) #3
commit-bot: I haz the power
Presubmit check for 13047009-1 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-25 23:31:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/13047009/1
7 years, 9 months ago (2013-03-25 23:38:35 UTC) #5
craigdh
7 years, 9 months ago (2013-03-26 00:27:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r190524 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698