Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: src/interface-descriptors.h

Issue 1304633002: Correctify instanceof and make it optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add arm64 port. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interface-descriptors.h
diff --git a/src/interface-descriptors.h b/src/interface-descriptors.h
index a016797623a4331fdec2acab881d2899898f84ba..11820ef594f2952b9cb1b71e78862e61020bb117 100644
--- a/src/interface-descriptors.h
+++ b/src/interface-descriptors.h
@@ -19,7 +19,7 @@ class PlatformInterfaceDescriptor;
V(StoreTransition) \
V(VectorStoreICTrampoline) \
V(VectorStoreIC) \
- V(Instanceof) \
+ V(InstanceOf) \
V(LoadWithVector) \
V(FastNewClosure) \
V(FastNewContext) \
@@ -268,13 +268,13 @@ class StoreTransitionDescriptor : public StoreDescriptor {
};
-class InstanceofDescriptor : public CallInterfaceDescriptor {
+class InstanceOfDescriptor final : public CallInterfaceDescriptor {
public:
- DECLARE_DESCRIPTOR(InstanceofDescriptor, CallInterfaceDescriptor)
+ DECLARE_DESCRIPTOR(InstanceOfDescriptor, CallInterfaceDescriptor)
enum ParameterIndices { kLeftIndex, kRightIndex, kParameterCount };
- static const Register left();
- static const Register right();
+ static const Register LeftRegister();
+ static const Register RightRegister();
};

Powered by Google App Engine
This is Rietveld 408576698