Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304623002: Make blink classes and structures in core/css fast-allocated (Closed)

Created:
5 years, 4 months ago by tasak
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, Eric Willigers, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make blink classes and structures in core/css fast-allocated Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200982

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing (Fixed windows compile error) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -7 lines) Patch
M Source/core/css/CSSDefaultStyleSheets.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFace.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFaceSource.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSImageSetValue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperty.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSPropertyMetadata.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSTestHelper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSToLengthConversionData.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/DocumentFontFaceSet.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/FontFaceSet.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/FontSize.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/css/HashTools.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/LocalFontFaceSource.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryExp.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/MediaValuesCached.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/RemoteFontFaceSource.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/RuleSet.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StyleColor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/StyleRuleImport.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserObserverWrapper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserString.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserToken.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserTokenRange.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserValues.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSTokenizer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/MediaQueryBlockWatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/CSSPropertyPriority.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/MatchedPropertiesCache.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolverStats.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
tasak
Would you review this CL?
5 years, 4 months ago (2015-08-19 10:51:48 UTC) #2
haraken
LGTM https://codereview.chromium.org/1304623002/diff/1/Source/core/css/CSSTestHelper.h File Source/core/css/CSSTestHelper.h (right): https://codereview.chromium.org/1304623002/diff/1/Source/core/css/CSSTestHelper.h#newcode60 Source/core/css/CSSTestHelper.h:60: RefPtrWillBePersistent<CSSStyleSheet> m_styleSheet; Not related to this CL, these ...
5 years, 4 months ago (2015-08-19 11:03:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304623002/20001
5 years, 4 months ago (2015-08-20 01:54:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22091)
5 years, 4 months ago (2015-08-20 02:30:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304623002/20001
5 years, 4 months ago (2015-08-21 06:01:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58851)
5 years, 4 months ago (2015-08-21 10:19:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304623002/20001
5 years, 4 months ago (2015-08-21 10:20:44 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 12:21:21 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200982

Powered by Google App Engine
This is Rietveld 408576698