Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1304593002: X87: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. port 00df60d1c6943a10fb5ca84fce2c017dcd2001f5 (r30219). original commit message: Makes the following modifications to the interpreter builtins and InterpreterAssembler: - Adds an accumulator register and initializes it to undefined() - Adds a register file pointer register and use it instead of FramePointer to access registers - Modifies builtin to support functions with 0 regiters in the register file - Modifies builtin to Call rather than TailCall to first bytecode handler. BUG= Committed: https://crrev.com/8116f95c965e31cbd9df1004ece619d252679a69 Cr-Commit-Position: refs/heads/master@{#30289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M src/x87/builtins-x87.cc View 4 chunks +38 lines, -21 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-21 08:50:21 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-21 09:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304593002/1
5 years, 4 months ago (2015-08-21 09:40:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 10:14:56 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 10:15:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8116f95c965e31cbd9df1004ece619d252679a69
Cr-Commit-Position: refs/heads/master@{#30289}

Powered by Google App Engine
This is Rietveld 408576698