Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1304573004: Added UMA statistics for change passwords in the Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | components/password_manager/core/browser/password_manager_metrics_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index b0e6f863c87d02505f853ece870401caa319d8f4..a96a7bb51d15ea546472853425b03e70fe25fdab 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -149,7 +149,8 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Update the password store entry for |credentials_to_update|, using the
// password from |pending_credentials_|. It modifies |pending_credentials_|.
- // |credentials_to_update| should be one of |best_matches_|.
+ // |credentials_to_update| should be one of |best_matches_| or
+ // |pending_credentials_|.
void Update(const autofill::PasswordForm& credentials_to_update);
// Call these if/when we know the form submission worked or failed.
« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | components/password_manager/core/browser/password_manager_metrics_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698