Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2647)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 1304573004: Added UMA statistics for change passwords in the Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed reviewers comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index 4dea78a3cc33b94ca5bb700b7781d0d856d762f3..4c3f520caf7ca84c7c142c40a7dd459f7190dc08 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -31,6 +31,8 @@ enum UIDisplayDisposition {
AUTOMATIC_GENERATED_PASSWORD_CONFIRMATION,
AUTOMATIC_CREDENTIAL_REQUEST,
AUTOMATIC_SIGNIN_TOAST,
+ MANUAL_WITH_PASSWORD_PENDING_UPDATE,
+ AUTOMATIC_WITH_PASSWORD_PENDING_UPDATE,
NUM_DISPLAY_DISPOSITIONS
};
@@ -87,6 +89,23 @@ enum PasswordSubmissionEvent {
SUBMISSION_EVENT_ENUM_COUNT
};
+enum UpdatePasswordSubmissionEvent {
+ NO_ACCOUNTS_CLICKED_UPDATE,
+ NO_ACCOUNTS_CLICKED_NOPE,
+ NO_ACCOUNTS_NO_INTERACTION,
+ ONE_ACCOUNT_CLICKED_UPDATE,
+ ONE_ACCOUNT_CLICKED_NOPE,
+ ONE_ACCOUNT_NO_INTERACTION,
+ MULTIPLE_ACCOUNTS_CLICKED_UPDATE,
+ MULTIPLE_ACCOUNTS_CLICKED_NOPE,
+ MULTIPLE_ACCOUNTS_NO_INTERACTION,
+ PASSWORD_OVERRIDDEN_CLICKED_UPDATE,
+ PASSWORD_OVERRIDDEN_CLICKED_NOPE,
+ PASSWORD_OVERRIDDEN_NO_INTERACTION,
+ UPDATE_PASSWORD_EVENT_COUNT,
+ NO_UPDATE_SUBMISSION
+};
+
// We monitor the performance of the save password heuristic for a handful of
// domains. For privacy reasons we are not reporting UMA signals by domain, but
// by a domain group. A domain group can contain multiple domains, and a domain
@@ -144,6 +163,9 @@ void LogPasswordSyncState(PasswordSyncState state);
// Log submission events related to generation.
void LogPasswordGenerationSubmissionEvent(PasswordSubmissionEvent event);
+// Log submission events related to password update.
+void LogUpdatePasswordSubmissionEvent(UpdatePasswordSubmissionEvent event);
+
} // namespace metrics_util
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698