Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 1304573004: Added UMA statistics for change passwords in the Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index 202cae9ac8d50580859e83434a660fcb665b8e36..731957b39098495486c124acb4aaa85191adb5f8 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -48,6 +48,10 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Called by the view code when the "Cancel" button in clicked by the user.
void OnCancelClicked();
+ // Called by the view code when the "Nope" button in clicked by the user in
+ // update bubble.
+ void OnNopeUpdateClicked();
+
// Called by the view code when the "Never for this site." button in clicked
// by the user.
void OnNeverForThisSiteClicked();
@@ -148,9 +152,16 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
static int PasswordFieldWidth();
private:
+ enum UserBehaviorOnUpdateBubble {
+ UPDATE_CLICKED,
+ NOPE_CLICKED,
+ NO_INTERACTION
+ };
// Updates |title_| and |title_brand_link_range_| for the
// PENDING_PASSWORD_STATE.
void UpdatePendingStateTitle();
+ password_manager::metrics_util::UpdatePasswordSubmissionEvent
+ GetUpdateDismissalReason(UserBehaviorOnUpdateBubble behavior) const;
// URL of the page from where this bubble was triggered.
GURL origin_;
password_manager::ui::State state_;
@@ -167,6 +178,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
gfx::Range save_confirmation_link_range_;
password_manager::metrics_util::UIDisplayDisposition display_disposition_;
password_manager::metrics_util::UIDismissalReason dismissal_reason_;
+ password_manager::metrics_util::UpdatePasswordSubmissionEvent
+ update_password_submission_event_;
DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);
};
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698