components/password_manager/core/browser/password_manager_metrics_util.cc - Issue 1304573004: Added UMA statistics for change passwords in the Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.cc

Issue 1304573004: Added UMA statistics for change passwords in the Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('K') | « components/password_manager/core/browser/password_manager_metrics_util.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.cc

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.cc b/components/password_manager/core/browser/password_manager_metrics_util.cc

index f2dfa455e19de06211f778756a53457b1e1fff1f..fe20b49746c1a959424ae77725c41b321ba9450b 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.cc

+++ b/components/password_manager/core/browser/password_manager_metrics_util.cc

@@ -169,6 +169,12 @@ void LogPasswordGenerationSubmissionEvent(PasswordSubmissionEvent event) {

SUBMISSION_EVENT_ENUM_COUNT);

}

+void LogUpdatePasswordSubmissionEvent(UpdatePasswordSubmissionEvent event) {

+ DCHECK_LT(event, UPDATE_PASSWORD_EVENT_COUNT);

+ UMA_HISTOGRAM_ENUMERATION("PasswordManager.UpdatePasswordSubmissionEvent",

+ event, UPDATE_PASSWORD_EVENT_COUNT);

} // namespace metrics_util

} // namespace password_manager