Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1304573002:
Oilpan: Add CrossThreadWeakPersistent. (Closed)
|
Created:
5 years, 4 months ago by Yuta Kitamura Modified:
5 years, 4 months ago CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium) Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/remotes/origin/master Project:
blink Visibility:
Public. |
DescriptionOilpan: Add CrossThreadWeakPersistent.
The necessity of CrossThreadWeakPersistent arose in
https://codereview.chromium.org/1296243004/.
BUG=420515
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200889
Patch Set 1 #Patch Set 2 : Add a test. #
Messages
Total messages: 23 (9 generated)
FYI: WIP, tests to be added.
The change looks good.
Added a test, no longer WIP. PTAL.
LGTM
The CQ bit was checked by yutak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304573002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by yutak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304573002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by yutak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304573002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by yutak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304573002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by yutak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304573002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200889 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
