Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1304553002: Remove the deprecated messageevent API (Closed)

Created:
5 years, 4 months ago by sgurun-gerrit only
Modified:
5 years, 4 months ago
Reviewers:
dcheng
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the deprecated messageevent API BUG=473258 Message ports were using the source frame's execution context rather than the targets when ports were transferred from a frame to another. This seems to be leaky and also creates difficulties when implementing message port support for android webview and OOPIF. Use the target instead. This is patch 3 of 3 and removes the deprecated API. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200786

Patch Set 1 #

Patch Set 2 : add class documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M Source/web/WebDOMMessageEvent.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M public/web/WebDOMMessageEvent.h View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sgurun-gerrit only
On 2015/08/19 00:13:17, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:dcheng@chromium.org PTAL, thanks
5 years, 4 months ago (2015-08-19 00:13:28 UTC) #2
dcheng
lgtm
5 years, 4 months ago (2015-08-19 00:55:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304553002/20001
5 years, 4 months ago (2015-08-19 00:58:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/92257)
5 years, 4 months ago (2015-08-19 01:50:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304553002/20001
5 years, 4 months ago (2015-08-19 02:08:44 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:06:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200786

Powered by Google App Engine
This is Rietveld 408576698