Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304503002: Fix sub-pixel handling of transparency boxes in DPL (Closed)

Created:
5 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix sub-pixel handling of transparency boxes in DPL DeprecatedPaintLayer::transparencyClipBox and DeprecatedPaintLayer::paintingExtent used to take a sub-pixel accumulation value as an argument, but that value was inconsistent and often incorrect. DeprecatedPaintLayer's have a sub-pixel accumulation value as a member for this purpose, so this patch makes these methods use it. This fixes some cases where partially transparent nested objects would be clipped incorrectly at certain sub-pixel offsets. BUG=476139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200922

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -13 lines) Patch
A LayoutTests/fast/sub-pixel/nested-transparency-layer-clipping.html View 1 chunk +22 lines, -0 lines 1 comment Download
A LayoutTests/fast/sub-pixel/nested-transparency-layer-clipping-expected.html View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
leviw_travelin_and_unemployed
5 years, 4 months ago (2015-08-18 23:55:04 UTC) #2
leviw_travelin_and_unemployed
ping
5 years, 4 months ago (2015-08-20 00:36:33 UTC) #3
eae
LGTM Much nicer, thank you. https://codereview.chromium.org/1304503002/diff/1/LayoutTests/fast/sub-pixel/nested-transparency-layer-clipping.html File LayoutTests/fast/sub-pixel/nested-transparency-layer-clipping.html (right): https://codereview.chromium.org/1304503002/diff/1/LayoutTests/fast/sub-pixel/nested-transparency-layer-clipping.html#newcode1 LayoutTests/fast/sub-pixel/nested-transparency-layer-clipping.html:1: <!DOCTYPE html> What, no ...
5 years, 4 months ago (2015-08-20 17:01:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304503002/1
5 years, 4 months ago (2015-08-20 17:02:09 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 19:01:38 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200922

Powered by Google App Engine
This is Rietveld 408576698