Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304493002: SkPDF: Simplify PDFStream / emitObject() const (Closed)

Created:
5 years, 4 months ago by hal.canary
Modified:
5 years, 4 months ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Simplify PDFStream / emitObject() const Compress SkPDFStream's data on setData(), not emitObject(); no longer stateful. SkPDFObject::emitObject is now const. This makes it easier to reason about state. Minimal performance gains. Committed: https://skia.googlesource.com/skia/+/a060eba0836f98902ca078d5f9fc6191ba0c0a52

Patch Set 1 #

Patch Set 2 : 2015-08-18 (Tuesday) 19:01:48 EDT #

Patch Set 3 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -89 lines) Patch
M src/pdf/SkPDFBitmap.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFontImpl.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFGraphicState.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/pdf/SkPDFStream.h View 1 1 chunk +11 lines, -23 lines 0 comments Download
M src/pdf/SkPDFStream.cpp View 1 1 chunk +28 lines, -43 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304493002/1
5 years, 4 months ago (2015-08-18 21:52:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304493002/20001
5 years, 4 months ago (2015-08-18 23:04:29 UTC) #4
hal.canary
PTAL
5 years, 4 months ago (2015-08-18 23:09:23 UTC) #6
mtklein_C
lgtm
5 years, 4 months ago (2015-08-19 19:13:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304493002/40001
5 years, 4 months ago (2015-08-19 19:16:11 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 19:26:48 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a060eba0836f98902ca078d5f9fc6191ba0c0a52

Powered by Google App Engine
This is Rietveld 408576698