Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1304473003: Add dsinclair and simonhatch as owners for tracing* in components/ (Closed)

Created:
5 years, 4 months ago by Zhen Wang
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dsinclair and simonhatch as owners for tracing* in components/ This CL adds dsinclair and simonhatch as the owners for tracing* in components/. This is consistent with the owners file at components/tracing/OWNERS. This is mainly for tracing.gyp and tracing_nacl.gyp. Committed: https://crrev.com/c7da89f96f7010199fb0ae221da1cac82f552771 Cr-Commit-Position: refs/heads/master@{#344219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Zhen Wang
ptal
5 years, 4 months ago (2015-08-18 23:30:20 UTC) #2
Zhen Wang
+blundell for the OWNERS file itself.
5 years, 4 months ago (2015-08-18 23:41:52 UTC) #4
nduca
lgtm
5 years, 4 months ago (2015-08-18 23:43:13 UTC) #5
blundell
lgtm
5 years, 4 months ago (2015-08-19 08:36:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304473003/1
5 years, 4 months ago (2015-08-19 14:19:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 14:24:13 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 14:24:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7da89f96f7010199fb0ae221da1cac82f552771
Cr-Commit-Position: refs/heads/master@{#344219}

Powered by Google App Engine
This is Rietveld 408576698