Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: runtime/vm/thread.cc

Issue 1304473002: Ensure helper threads get empty initial store buffer block. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Ensure empty initial block for helper threads. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread.cc
diff --git a/runtime/vm/thread.cc b/runtime/vm/thread.cc
index 654d02ff9ebef8166d5929d4c019247c805334f5..fdd3272e340ecf1029b9a87c5c067bbcd3b80440 100644
--- a/runtime/vm/thread.cc
+++ b/runtime/vm/thread.cc
@@ -173,7 +173,9 @@ void Thread::EnterIsolateAsHelper(Isolate* isolate) {
ASSERT(thread->isolate() == NULL);
thread->isolate_ = isolate;
ASSERT(thread->store_buffer_block_ == NULL);
- thread->StoreBufferAcquire();
+ // TODO(koda): Use StoreBufferAcquire once we properly flush before Scavenge.
+ thread->store_buffer_block_ =
+ thread->isolate()->store_buffer()->PopEmptyBlock();
ASSERT(isolate->heap() != NULL);
thread->heap_ = isolate->heap();
ASSERT(thread->thread_state() == NULL);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698