HTTPTransportMac: CFStream Read() must always set at_eof

util/net/http_transport_mac.mm

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 69 matching lines @@
                                void* info) {
     return TRUE;
   }
 
   static CFIndex Read(CFReadStreamRef stream,
                       UInt8* buffer,
                       CFIndex buffer_length,
                       CFStreamError* error,
                       Boolean* at_eof,
                       void* info) {
-    if (buffer_length == 0)
+    if (buffer_length == 0) {
+      *at_eof = FALSE;
       return 0;
+    }
 
     ssize_t bytes_read = GetStream(info)->GetBytesBuffer(buffer, buffer_length);
-    if (bytes_read == 0) {
-      *at_eof = TRUE;
-    } else if (bytes_read < 0) {
+    if (bytes_read < 0) {
       error->error = -1;
       error->domain = kCFStreamErrorDomainCustom;
+    } else {
+      *at_eof = bytes_read == 0;
     }
 
     return bytes_read;
   }
 
   static const UInt8* GetBuffer(CFReadStreamRef stream,
                                 CFIndex max_bytes_to_read,
                                 CFIndex* num_bytes_read,
                                 CFStreamError* error,
                                 Boolean* at_eof,
@@ skipping 105 matching lines @@
 }
 
 }  // namespace
 
 // static
 scoped_ptr<HTTPTransport> HTTPTransport::Create() {
   return scoped_ptr<HTTPTransport>(new HTTPTransportMac());
 }
 
 }  // namespace crashpad