HTTPTransportMac: CFStream Read() must always set at_eof

util/net/http_transport_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 260 matching lines @@
 
   HTTPHeaders headers;
   headers[kContentType] = kTextPlain;
   headers[kContentLength] = base::StringPrintf("%" PRIuS, strlen(kTextBody));
 
   HTTPTransportTestFixture test(headers, body_stream.Pass(), 200,
       &UnchunkedPlainText);
   test.Run();
 }
 
+TEST(HTTPTransport, Upload33k) {
+  // NSMutableURLRequest winds up calling into a CFReadStream’s Read() callback
+  // with a 32kB buffer. Make sure that it’s able to get everything when enough
+  // is available to fill this buffer, requiring more than one Read().
+
+  std::string request_string(33 * 1024, 'a');
+  scoped_ptr<HTTPBodyStream> body_stream(
+      new StringHTTPBodyStream(request_string));
+
+  HTTPHeaders headers;
+  headers[kContentType] = "application/octet-stream";
+  headers[kContentLength] = base::StringPrintf("%zu", request_string.size());

[Robert Sesek, 2015/08/18 19:35:07]

PRIuS instead of %zu.

+  HTTPTransportTestFixture test(headers, body_stream.Pass(), 200,
+      [](HTTPTransportTestFixture* fixture, const std::string& request) {
+        size_t body_start = request.rfind("\r\n");
+        EXPECT_EQ(33 * 1024u + 2, request.size() - body_start);
+      });
+  test.Run();
+}
+
 }  // namespace
 }  // namespace test
 }  // namespace crashpad