Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2800)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated the review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | content/browser/android/in_process/synchronous_compositor_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index 05fc56ce08c9f96adc64b2e809adef5b1a0cf62f..605d5db8b268358eee0642ba196684ccf530f5a9 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -2459,11 +2459,12 @@ class TestScrollOffsetDelegate : public LayerScrollOffsetDelegate {
virtual ~TestScrollOffsetDelegate() {}
- virtual void SetMaxScrollOffset(gfx::Vector2dF max_scroll_offset) OVERRIDE {
+ virtual void SetMaxScrollOffset(
+ const gfx::Vector2dF& max_scroll_offset) OVERRIDE {
max_scroll_offset_ = max_scroll_offset;
}
- virtual void SetTotalScrollOffset(gfx::Vector2dF new_value) OVERRIDE {
+ virtual void SetTotalScrollOffset(const gfx::Vector2dF& new_value) OVERRIDE {
last_set_scroll_offset_ = new_value;
}
@@ -2485,7 +2486,7 @@ class TestScrollOffsetDelegate : public LayerScrollOffsetDelegate {
return last_set_scroll_offset_;
}
- void set_getter_return_value(gfx::Vector2dF value) {
+ void set_getter_return_value(const gfx::Vector2dF& value) {
getter_return_value_ = value;
}
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | content/browser/android/in_process/synchronous_compositor_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698