cc/test/animation_test_common.cc - Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/animation_test_common.cc

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/test/animation_test_common.cc

diff --git a/cc/test/animation_test_common.cc b/cc/test/animation_test_common.cc

index 01e33bbff4c0136cc1b6831f809ec0cf9bce12f1..a9a674f302d7db23889dcc1621d6088ba8e12362 100644

--- a/cc/test/animation_test_common.cc

+++ b/cc/test/animation_test_common.cc

@@ -200,7 +200,7 @@ void FakeLayerAnimationValueObserver::OnTransformAnimated(

}

void FakeLayerAnimationValueObserver::OnScrollOffsetAnimated(

- gfx::Vector2dF scroll_offset) {

+ const gfx::Vector2dF& scroll_offset) {

scroll_offset_ = scroll_offset;

}

« no previous file with comments | « cc/test/animation_test_common.h ('k') | cc/trees/layer_sorter.cc » ('j') | no next file with comments »