cc/layers/layer.cc - Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer.cc

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/layer.cc

diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc

index 045ea73c0f9028601d960545bd98ffeb7599475e..f5850067c415af5bc11f9495d2933533904a32e7 100644

--- a/cc/layers/layer.cc

+++ b/cc/layers/layer.cc

@@ -1066,7 +1066,7 @@ void Layer::OnTransformAnimated(const gfx::Transform& transform) {

transform_ = transform;

}

-void Layer::OnScrollOffsetAnimated(gfx::Vector2dF scroll_offset) {

+void Layer::OnScrollOffsetAnimated(const gfx::Vector2dF& scroll_offset) {

// Do nothing. Scroll deltas will be sent from the compositor thread back

// to the main thread in the same manner as during non-animated

// compositor-driven scrolling.

« no previous file with comments | « cc/layers/layer.h ('k') | cc/layers/layer_impl.h » ('j') | no next file with comments »