cc/input/top_controls_manager.h - Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/input/top_controls_manager.h

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/input/top_controls_manager.h

diff --git a/cc/input/top_controls_manager.h b/cc/input/top_controls_manager.h

index 246efba5b9ae36c1d87673d94187883f355868ea..7d631d85bb1b1b419b73128a7161144e27a21e07 100644

--- a/cc/input/top_controls_manager.h

+++ b/cc/input/top_controls_manager.h

@@ -53,7 +53,7 @@ class CC_EXPORT TopControlsManager

bool animate);

void ScrollBegin();

- gfx::Vector2dF ScrollBy(const gfx::Vector2dF pending_delta);

+ gfx::Vector2dF ScrollBy(const gfx::Vector2dF& pending_delta);

void ScrollEnd();

// The caller should ensure that |Pinch{Begin,End}| are called within

« no previous file with comments | « cc/input/page_scale_animation.cc ('k') | cc/input/top_controls_manager.cc » ('j') | no next file with comments »