[#5] Pass gfx structs by const ref (gfx::Vector2dF)

cc/input/layer_scroll_offset_delegate.h

Index: cc/input/layer_scroll_offset_delegate.h
diff --git a/cc/input/layer_scroll_offset_delegate.h b/cc/input/layer_scroll_offset_delegate.h
index 1ee97367be70cf3b91d752de21dba852dbce4edc..034daab432174698aff625d375597841c20e3f80 100644
--- a/cc/input/layer_scroll_offset_delegate.h
+++ b/cc/input/layer_scroll_offset_delegate.h
@@ -19,11 +19,11 @@ class LayerScrollOffsetDelegate {
  public:
   // This is called by the compositor to notify the delegate what is the upper
   // total scroll offset bound.
-  virtual void SetMaxScrollOffset(gfx::Vector2dF max_scroll_offset) = 0;
+  virtual void SetMaxScrollOffset(const gfx::Vector2dF& max_scroll_offset) = 0;
 

[r.kasibhatla, 2014/01/21 10:28:04]

Missed overriding the function in following files:
1. content/browser/android/in_process/synchronous_compositor_impl.h
2. content/browser/android/in_process/synchronous_compositor_impl.cc

You might also need to check the SetMaxScrollOffset in layer_impl.h/.cc. It
seems it is wrong that in param is gfx::Vector2d but passing & storing param is
gfx::Vector2dF. It might need to be corrected.

   // This is called by the compositor when the scroll offset of the layer would
   // have otherwise changed.
-  virtual void SetTotalScrollOffset(gfx::Vector2dF new_value) = 0;
+  virtual void SetTotalScrollOffset(const gfx::Vector2dF& new_value) = 0;

[r.kasibhatla, 2014/01/21 10:28:04]

Missed overriding the following files:
1. content/browser/android/in_process/synchronous_compositor_impl.h
2. content/browser/android/in_process/synchronous_compositor_impl.cc

 
   // This is called by the compositor to query the current scroll offset of the
   // layer.