Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: cc/animation/scroll_offset_animation_curve.h

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated the review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_ANIMATION_SCROLL_OFFSET_ANIMATION_CURVE_H_ 5 #ifndef CC_ANIMATION_SCROLL_OFFSET_ANIMATION_CURVE_H_
6 #define CC_ANIMATION_SCROLL_OFFSET_ANIMATION_CURVE_H_ 6 #define CC_ANIMATION_SCROLL_OFFSET_ANIMATION_CURVE_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "cc/animation/animation_curve.h" 9 #include "cc/animation/animation_curve.h"
10 #include "cc/base/cc_export.h" 10 #include "cc/base/cc_export.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 class TimingFunction; 14 class TimingFunction;
15 15
16 class CC_EXPORT ScrollOffsetAnimationCurve : public AnimationCurve { 16 class CC_EXPORT ScrollOffsetAnimationCurve : public AnimationCurve {
17 public: 17 public:
18 static scoped_ptr<ScrollOffsetAnimationCurve> Create( 18 static scoped_ptr<ScrollOffsetAnimationCurve> Create(
19 gfx::Vector2dF target_value, 19 const gfx::Vector2dF& target_value,
20 scoped_ptr<TimingFunction> timing_function); 20 scoped_ptr<TimingFunction> timing_function);
21 21
22 virtual ~ScrollOffsetAnimationCurve(); 22 virtual ~ScrollOffsetAnimationCurve();
23 23
24 void SetInitialValue(gfx::Vector2dF initial_value); 24 void SetInitialValue(const gfx::Vector2dF& initial_value);
25 gfx::Vector2dF GetValue(double t) const; 25 gfx::Vector2dF GetValue(double t) const;
26 26
27 // AnimationCurve implementation 27 // AnimationCurve implementation
28 virtual double Duration() const OVERRIDE; 28 virtual double Duration() const OVERRIDE;
29 virtual CurveType Type() const OVERRIDE; 29 virtual CurveType Type() const OVERRIDE;
30 virtual scoped_ptr<AnimationCurve> Clone() const OVERRIDE; 30 virtual scoped_ptr<AnimationCurve> Clone() const OVERRIDE;
31 31
32 private: 32 private:
33 ScrollOffsetAnimationCurve(gfx::Vector2dF target_value, 33 ScrollOffsetAnimationCurve(const gfx::Vector2dF& target_value,
34 scoped_ptr <TimingFunction> timing_function); 34 scoped_ptr <TimingFunction> timing_function);
35 35
36 gfx::Vector2dF initial_value_; 36 gfx::Vector2dF initial_value_;
37 gfx::Vector2dF target_value_; 37 gfx::Vector2dF target_value_;
38 double duration_; 38 double duration_;
39 39
40 scoped_ptr<TimingFunction> timing_function_; 40 scoped_ptr<TimingFunction> timing_function_;
41 41
42 DISALLOW_COPY_AND_ASSIGN(ScrollOffsetAnimationCurve); 42 DISALLOW_COPY_AND_ASSIGN(ScrollOffsetAnimationCurve);
43 }; 43 };
44 44
45 } // namespace cc 45 } // namespace cc
46 46
47 #endif // CC_ANIMATION_SCROLL_OFFSET_ANIMATION_CURVE_H_ 47 #endif // CC_ANIMATION_SCROLL_OFFSET_ANIMATION_CURVE_H_
OLDNEW
« no previous file with comments | « cc/animation/layer_animation_value_observer.h ('k') | cc/animation/scroll_offset_animation_curve.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698