content/browser/android/in_process/synchronous_compositor_impl.h - Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF)

Side by Side Diff: content/browser/android/in_process/synchronous_compositor_impl.h

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing the trybot results Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | content/browser/android/in_process/synchronous_compositor_impl.cc » ('j') | content/renderer/input/input_handler_proxy_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_ANDROID_IN_PROCESS_SYNCHRONOUS_COMPOSITOR_IMPL_H_	5 #ifndef CONTENT_BROWSER_ANDROID_IN_PROCESS_SYNCHRONOUS_COMPOSITOR_IMPL_H_

6 #define CONTENT_BROWSER_ANDROID_IN_PROCESS_SYNCHRONOUS_COMPOSITOR_IMPL_H_	6 #define CONTENT_BROWSER_ANDROID_IN_PROCESS_SYNCHRONOUS_COMPOSITOR_IMPL_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "base/memory/scoped_ptr.h"	10 #include "base/memory/scoped_ptr.h"

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 virtual void DidBindOutputSurface(	66 virtual void DidBindOutputSurface(

67 SynchronousCompositorOutputSurface* output_surface) OVERRIDE;	67 SynchronousCompositorOutputSurface* output_surface) OVERRIDE;

68 virtual void DidDestroySynchronousOutputSurface(	68 virtual void DidDestroySynchronousOutputSurface(

69 SynchronousCompositorOutputSurface* output_surface) OVERRIDE;	69 SynchronousCompositorOutputSurface* output_surface) OVERRIDE;

70 virtual void SetContinuousInvalidate(bool enable) OVERRIDE;	70 virtual void SetContinuousInvalidate(bool enable) OVERRIDE;

71 virtual void UpdateFrameMetaData(	71 virtual void UpdateFrameMetaData(

72 const cc::CompositorFrameMetadata& frame_info) OVERRIDE;	72 const cc::CompositorFrameMetadata& frame_info) OVERRIDE;

73 virtual void DidActivatePendingTree() OVERRIDE;	73 virtual void DidActivatePendingTree() OVERRIDE;

74	74

75 // LayerScrollOffsetDelegate	75 // LayerScrollOffsetDelegate

76 virtual void SetMaxScrollOffset(gfx::Vector2dF max_scroll_offset) OVERRIDE;	76 virtual void SetMaxScrollOffset(

77 virtual void SetTotalScrollOffset(gfx::Vector2dF new_value) OVERRIDE;	77 const gfx::Vector2dF& max_scroll_offset) OVERRIDE;

	78 virtual void SetTotalScrollOffset(const gfx::Vector2dF& new_value) OVERRIDE;

78 virtual gfx::Vector2dF GetTotalScrollOffset() OVERRIDE;	79 virtual gfx::Vector2dF GetTotalScrollOffset() OVERRIDE;

79 virtual bool IsExternalFlingActive() const OVERRIDE;	80 virtual bool IsExternalFlingActive() const OVERRIDE;

80 virtual void SetTotalPageScaleFactor(float page_scale_factor) OVERRIDE;	81 virtual void SetTotalPageScaleFactor(float page_scale_factor) OVERRIDE;

81 virtual void SetScrollableSize(const gfx::SizeF& scrollable_size) OVERRIDE;	82 virtual void SetScrollableSize(const gfx::SizeF& scrollable_size) OVERRIDE;

82	83

83 void SetInputHandler(cc::InputHandler* input_handler);	84 void SetInputHandler(cc::InputHandler* input_handler);

84 void DidOverscroll(const cc::DidOverscrollParams& params);	85 void DidOverscroll(const cc::DidOverscrollParams& params);

85 void DidStopFlinging();	86 void DidStopFlinging();

86	87

87 private:	88 private:

88 explicit SynchronousCompositorImpl(WebContents* contents);	89 explicit SynchronousCompositorImpl(WebContents* contents);

89 virtual ~SynchronousCompositorImpl();	90 virtual ~SynchronousCompositorImpl();

90 friend class WebContentsUserData<SynchronousCompositorImpl>;	91 friend class WebContentsUserData<SynchronousCompositorImpl>;

91	92

92 void DidCreateSynchronousOutputSurface(	93 void DidCreateSynchronousOutputSurface(

93 SynchronousCompositorOutputSurface* output_surface);	94 SynchronousCompositorOutputSurface* output_surface);

94 bool CalledOnValidThread() const;	95 bool CalledOnValidThread() const;

95	96

96 SynchronousCompositorClient* compositor_client_;	97 SynchronousCompositorClient* compositor_client_;

97 SynchronousCompositorOutputSurface* output_surface_;	98 SynchronousCompositorOutputSurface* output_surface_;

98 WebContents* contents_;	99 WebContents* contents_;

99 cc::InputHandler* input_handler_;	100 cc::InputHandler* input_handler_;

100	101

101 DISALLOW_COPY_AND_ASSIGN(SynchronousCompositorImpl);	102 DISALLOW_COPY_AND_ASSIGN(SynchronousCompositorImpl);

102 };	103 };

103	104

104 } // namespace content	105 } // namespace content

105	106

106 #endif // CONTENT_BROWSER_ANDROID_IN_PROCESS_SYNCHRONOUS_COMPOSITOR_IMPL_H_	107 #endif // CONTENT_BROWSER_ANDROID_IN_PROCESS_SYNCHRONOUS_COMPOSITOR_IMPL_H_

OLD	NEW