Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: pkg/stack_trace/test/frame_test.dart

Issue 130443002: Properly parse V8 lines involving eval in pkg/stack_trace. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/stack_trace/lib/src/frame.dart ('K') | « pkg/stack_trace/lib/src/frame.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/test/frame_test.dart
diff --git a/pkg/stack_trace/test/frame_test.dart b/pkg/stack_trace/test/frame_test.dart
index 9722d38df3dbcda521f7780c070ff207de0ce263..482794c310d379beb97d150293da4032e266f599 100644
--- a/pkg/stack_trace/test/frame_test.dart
+++ b/pkg/stack_trace/test/frame_test.dart
@@ -149,6 +149,36 @@ void main() {
expect(frame.member, equals('VW.call\$0'));
});
+ test('parses a basic eval stack frame correctly', () {
+ var frame = new Frame.parseV8(" at eval (eval at <anonymous> "
+ "(http://pub.dartlang.org/stuff.dart.js:560:28))");
+ expect(frame.uri,
+ equals(Uri.parse("http://pub.dartlang.org/stuff.dart.js")));
+ expect(frame.line, equals(560));
+ expect(frame.column, equals(28));
+ expect(frame.member, equals('eval'));
+ });
+
+ test('parses an eval stack frame with inner position info correctly', () {
+ var frame = new Frame.parseV8(" at eval (eval at <anonymous> "
+ "(http://pub.dartlang.org/stuff.dart.js:560:28), <anonymous>:3:28)");
+ expect(frame.uri,
+ equals(Uri.parse("http://pub.dartlang.org/stuff.dart.js")));
+ expect(frame.line, equals(560));
+ expect(frame.column, equals(28));
+ expect(frame.member, equals('eval'));
+ });
+
+ test('parses a nested eval stack frame correctly', () {
+ var frame = new Frame.parseV8(" at eval (eval at <anonymous> "
+ "(eval at sub (http://pub.dartlang.org/stuff.dart.js:560:28)))");
+ expect(frame.uri,
+ equals(Uri.parse("http://pub.dartlang.org/stuff.dart.js")));
+ expect(frame.line, equals(560));
+ expect(frame.column, equals(28));
+ expect(frame.member, equals('eval'));
+ });
+
test('converts "<anonymous>" to "<fn>"', () {
String parsedMember(String member) =>
new Frame.parseV8(' at $member (foo:0:0)').member;
« pkg/stack_trace/lib/src/frame.dart ('K') | « pkg/stack_trace/lib/src/frame.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698