Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2378)

Issue 1304413007: Revert of Deactivate Parser Bookmarks (Closed)

Created:
5 years, 3 months ago by Michael Hablich
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Deactivate Parser Bookmarks (patchset #1 id:1 of https://codereview.chromium.org/1315173007/ ) Reason for revert: Tanks performance (Mandreel latency). A simple deactivation will not work. Original issue's description: > Deactivate Parser Bookmarks. > > Bookmarks may create a race condition which > results in syntax errors. The more files are parsed > in parallel the higher the probability that the error > occurs. > Unfortunately it is not possible to simply revert the > CLs related to Bookmarks. > > BUG=chromium:527930, chromium:510825 > LOG=Y > > Committed: https://crrev.com/129593b40eb69d93ba626601bfda046a95cda0e7 > Cr-Commit-Position: refs/heads/master@{#30594} TBR=vogelheim@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:527930, chromium:510825, chromium:528852 Committed: https://crrev.com/ce1059ff0fd0f4064a4b6005335e60013f50fbe1 Cr-Commit-Position: refs/heads/master@{#30607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/parser.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of Deactivate Parser Bookmarks
5 years, 3 months ago (2015-09-07 07:49:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304413007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304413007/1
5 years, 3 months ago (2015-09-07 07:49:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 07:50:01 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 07:50:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce1059ff0fd0f4064a4b6005335e60013f50fbe1
Cr-Commit-Position: refs/heads/master@{#30607}

Powered by Google App Engine
This is Rietveld 408576698