Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issue 13044024: Move shared_memory into base/memory subdirectory. (Closed)

Created:
7 years, 8 months ago by brettw
Modified:
7 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, sail+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move shared_memory into base/memory subdirectory. This leaves a forwarding header in place so all calling code can be updated asynchronously. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191392

Patch Set 1 #

Patch Set 2 : add forwarding include #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1638 lines) Patch
M base/base.gyp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M base/base.gypi View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
A + base/memory/shared_memory.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/shared_memory_android.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/shared_memory_nacl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/shared_memory_posix.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/shared_memory_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/shared_memory_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/shared_memory.h View 1 2 1 chunk +4 lines, -275 lines 0 comments Download
D base/shared_memory_android.cc View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D base/shared_memory_nacl.cc View 1 2 1 chunk +0 lines, -158 lines 0 comments Download
D base/shared_memory_posix.cc View 1 2 1 chunk +0 lines, -388 lines 0 comments Download
D base/shared_memory_unittest.cc View 1 2 1 chunk +0 lines, -492 lines 0 comments Download
D base/shared_memory_win.cc View 1 2 1 chunk +0 lines, -253 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
7 years, 8 months ago (2013-03-27 20:52:14 UTC) #1
jar (doing other things)
Did you use svn mv (or some git equivalent) to move the files, so that ...
7 years, 8 months ago (2013-03-28 00:31:47 UTC) #2
brettw
Yes, I used git mv which generally does the right thing but sometimes confuses the ...
7 years, 8 months ago (2013-03-28 04:13:06 UTC) #3
brettw
7 years, 8 months ago (2013-03-29 17:46:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r191392.

Powered by Google App Engine
This is Rietveld 408576698