chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm - Issue 13044014: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

Issue 13044014: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabling test for Mac (not implemented yet) Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_keybinding_registry.h ('k') | chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

index 1ee3c0f652ff0796967cc7d8273d8dac7a7211e2..2d2cfbc90e8f84d68447bd5a6191b288f062697f 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

@@ -21,6 +21,13 @@ void extensions::ExtensionKeybindingRegistry::SetShortcutHandlingSuspended(

ExtensionKeybindingRegistryCocoa::set_shortcut_handling_suspended(suspended);

}

+// static

+bool extensions::ExtensionKeybindingRegistry::IsChromeAccelerator(

+ const ui::Accelerator& accelerator) {

+ // TODO(finnur): Implement this.

Yoyo Zhou 2013/04/05 18:09:50 Is the issue that AcceleratorsCocoa doesn't give y

Finnur 2013/04/05 19:50:03 The issue is that the CL for Views and GTK was rea

+ return false;

bool ExtensionKeybindingRegistryCocoa::shortcut_handling_suspended_ = false;

ExtensionKeybindingRegistryCocoa::ExtensionKeybindingRegistryCocoa(