Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304393004: Change VideoCaptureDeliverFrameCB's signature (Closed)

Created:
5 years, 4 months ago by ajose
Modified:
5 years, 4 months ago
Reviewers:
bbudge, mcasas, DaleCurtis
CC:
chromium-reviews, hclam+watch_chromium.org, posciak+watch_chromium.org, jam, imcheng+watch_chromium.org, mlamouri+watch-content_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change VideoCaptureDeliverFrameCB's signature from |const base::TimeTicks&| to |base::TimeTicks|. BUG=524589 Committed: https://crrev.com/90685ba0c19e0de94116eb4eac5a6d355e1aac20 Cr-Commit-Position: refs/heads/master@{#345453}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M chrome/renderer/media/cast_rtp_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capture_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/video_source_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_adapter.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_track_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_capturer_source.h View 1 chunk +3 lines, -4 lines 1 comment Download

Messages

Total messages: 13 (3 generated)
ajose
PTAL.
5 years, 4 months ago (2015-08-25 18:50:45 UTC) #2
mcasas
LGTM FWIW https://codereview.chromium.org/1304393004/diff/1/media/base/video_capturer_source.h File media/base/video_capturer_source.h (right): https://codereview.chromium.org/1304393004/diff/1/media/base/video_capturer_source.h#newcode45 media/base/video_capturer_source.h:45: base::TimeTicks estimated_capture_time)> VideoCaptureDeliverFrameCB; nit: perhaps clearer like ...
5 years, 4 months ago (2015-08-25 21:24:00 UTC) #3
ajose
Hello! Just a straightforward change. dalecurtis@: Please review changes in content/renderer/media and media/base/video_capturer_source.h bbudge@: Please ...
5 years, 4 months ago (2015-08-25 21:29:30 UTC) #5
bbudge
content/renderer/pepper LGTM
5 years, 4 months ago (2015-08-25 21:36:46 UTC) #6
DaleCurtis
lgtm
5 years, 4 months ago (2015-08-25 22:03:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304393004/1
5 years, 4 months ago (2015-08-25 22:05:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 22:11:28 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/90685ba0c19e0de94116eb4eac5a6d355e1aac20 Cr-Commit-Position: refs/heads/master@{#345453}
5 years, 4 months ago (2015-08-25 22:12:18 UTC) #11
fgorski
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1304983005/ by fgorski@chromium.org. ...
5 years, 4 months ago (2015-08-25 22:26:35 UTC) #12
boliu
5 years, 4 months ago (2015-08-25 22:47:22 UTC) #13
Message was sent while issue was closed. 
FYI this collided mid-air with https://codereview.chromium.org/1233033002, ie
they both passed cq independently. Really unfortunate timing..

Powered by Google App Engine
This is Rietveld 408576698