Revert "Reland c91b178b07b0d - Delete dead signin code (SigninGlobalError)"

Revert "Reland c91b178b07b0d - Delete dead signin code (SigninGlobalError)"

This broke OSX. Revert for now (hopefully before branch point) and try again later.

BUG=523421
TBR=rogerta@chromium.org,sky@chromium.org

Committed: https://crrev.com/8c0780f4237a4a8b6be99cc1073a0df84abe501e
Cr-Commit-Position: refs/heads/master@{#344904}

[Evan Stade, 2015-08-21 21:50:11]

estade@chromium.org changed reviewers:
+ rogerta@chromium.org, sky@chromium.org

[Evan Stade, 2015-08-21 21:50:41]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-08-21 21:52:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304393002/1

[Evan Stade, 2015-08-21 22:00:16]

https://codereview.chromium.org/1304393002/diff/1/chrome/browser/signin/signi...
File chrome/browser/signin/signin_ui_util.cc (right):

https://codereview.chromium.org/1304393002/diff/1/chrome/browser/signin/signi...
chrome/browser/signin/signin_ui_util.cc:71: base::string16
GetSigninMenuLabel(Profile* profile) {
so to review, this is still used by the app menu (I was confused, but the app
menu is not the same as the wrench menu; it's in the global menu bar). i.e.
there, we still show signin state, including errors.

I think the reason the hotdog menu also broke is because this code called
SyncGlobalErrorFactory::GetForProfile(profile) which triggered an error to show
up in the hotdog menu. Without this call, nothing ever inits the sync global
error factory. Note that on Views, in toolbar_view.cc, we explicitly kickstart
this factory[1] which is something that we could copy on OSX, but it wouldn't
fix the app menu.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

To reland this patch, I'll basically just repeat all the views changes, and
avoid any changes to Mac, and this file and SigninGlobalError will become mac
only. If someone decides they no longer need to show signin errors in the app
menu, it can later be removed from mac as well.

[commit-bot: I haz the power, 2015-08-21 23:36:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-21 23:37:42]

Patchset 1 (id:??) landed as
https://crrev.com/8c0780f4237a4a8b6be99cc1073a0df84abe501e
Cr-Commit-Position: refs/heads/master@{#344904}