Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1304383004: Fix NavigationScheduler to correctly delay tasks (Closed)

Created:
5 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 3 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix NavigationScheduler to correctly delay tasks This fixes a bug introduced in https://codereview.chromium.org/1305933007 which replaced a call to startOneShot that takes seconds with a call to postDelayedTask that takes milliseconds BUG=497761, 510398, 528666 R=alexclarke@chromium.org TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-07 14:54:02 UTC) #1
alexclarke
lgtm
5 years, 3 months ago (2015-09-07 14:55:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304383004/1
5 years, 3 months ago (2015-09-07 14:56:17 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-07 14:56:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304383004/1
5 years, 3 months ago (2015-09-07 15:12:50 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 15:49:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201877

Powered by Google App Engine
This is Rietveld 408576698