Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304383003: dart2js cps: Add path-sensitive types by inserting refinement IR nodes. (Closed)

Created:
5 years, 3 months ago by asgerf
Modified:
5 years, 3 months ago
Reviewers:
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Add path-sensitive types by inserting refinement IR nodes. Refinement nodes are added: - after InvokeMethod, asserting the receiver is not null. - after a branch with a condition of form 'x is T' or 'x == CONST' CLOSED due to messy history. Reopened here: https://codereview.chromium.org/1330503003/ BUG=

Patch Set 1 #

Patch Set 2 : Remove gratuitous change #

Total comments: 1

Patch Set 3 : Fix hasTooManyIndexAccesses #

Patch Set 4 : Fix the fix #

Patch Set 5 : Sink continuations and generalize receiver refinement #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -21 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 2 3 4 5 5 chunks +91 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 1 2 3 4 1 chunk +267 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/cps_ir/remove_refinements.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 3 4 5 18 chunks +57 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
asgerf
https://codereview.chromium.org/1304383003/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (left): https://codereview.chromium.org/1304383003/diff/20001/pkg/compiler/lib/src/cps_ir/type_propagation.dart#oldcode1526 pkg/compiler/lib/src/cps_ir/type_propagation.dart:1526: if (isInterceptedSelector(getter)) return false; This was a duplicate check, ...
5 years, 3 months ago (2015-08-28 14:43:27 UTC) #2
asgerf
5 years, 3 months ago (2015-08-28 14:44:51 UTC) #5 
Think I messed up the email field in the first round so: ping

Powered by Google App Engine
This is Rietveld 408576698