Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: net/quic/quic_connection.cc

Issue 1304373010: relnote: n/a (changing DLOGs). Tidy up the DLOG messages on receipt of (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@QUIC_bugfix_101695854
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index a8763794fe9c755f62ad43559ca73a52017edad3..73ffbc4219ee09493417f48b4ff591ba8c61b492 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -907,7 +907,9 @@ bool QuicConnection::OnRstStreamFrame(const QuicRstStreamFrame& frame) {
if (debug_visitor_ != nullptr) {
debug_visitor_->OnRstStreamFrame(frame);
}
- DVLOG(1) << ENDPOINT << "Stream reset with error "
+ DVLOG(1) << ENDPOINT
+ << "RST_STREAM_FRAME received for stream: " << frame.stream_id
+ << " with error: "
<< QuicUtils::StreamErrorToString(frame.error_code);
if (FLAGS_quic_process_frames_inline) {
visitor_->OnRstStream(frame);
@@ -924,9 +926,9 @@ bool QuicConnection::OnConnectionCloseFrame(
if (debug_visitor_ != nullptr) {
debug_visitor_->OnConnectionCloseFrame(frame);
}
- DVLOG(1) << ENDPOINT << "Connection " << connection_id()
- << " closed with error "
- << QuicUtils::ErrorToString(frame.error_code)
+ DVLOG(1) << ENDPOINT << "CONNECTION_CLOSE_FRAME received for connection: "
+ << connection_id()
+ << " with error: " << QuicUtils::ErrorToString(frame.error_code)
<< " " << frame.error_details;
if (FLAGS_quic_process_frames_inline) {
CloseConnection(frame.error_code, true);
@@ -941,9 +943,10 @@ bool QuicConnection::OnGoAwayFrame(const QuicGoAwayFrame& frame) {
if (debug_visitor_ != nullptr) {
debug_visitor_->OnGoAwayFrame(frame);
}
- DVLOG(1) << ENDPOINT << "Go away received with error "
- << QuicUtils::ErrorToString(frame.error_code)
- << " and reason:" << frame.reason_phrase;
+ DVLOG(1) << ENDPOINT << "GOAWAY_FRAME received with last good stream: "
+ << frame.last_good_stream_id
+ << " and error: " << QuicUtils::ErrorToString(frame.error_code)
+ << " and reason: " << frame.reason_phrase;
goaway_received_ = true;
if (FLAGS_quic_process_frames_inline) {
@@ -960,8 +963,9 @@ bool QuicConnection::OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame) {
if (debug_visitor_ != nullptr) {
debug_visitor_->OnWindowUpdateFrame(frame);
}
- DVLOG(1) << ENDPOINT << "WindowUpdate received for stream: "
- << frame.stream_id << " with byte offset: " << frame.byte_offset;
+ DVLOG(1) << ENDPOINT
+ << "WINDOW_UPDATE_FRAME received for stream: " << frame.stream_id
+ << " with byte offset: " << frame.byte_offset;
if (FLAGS_quic_process_frames_inline) {
visitor_->OnWindowUpdateFrame(frame);
should_last_packet_instigate_acks_ = true;
@@ -976,8 +980,8 @@ bool QuicConnection::OnBlockedFrame(const QuicBlockedFrame& frame) {
if (debug_visitor_ != nullptr) {
debug_visitor_->OnBlockedFrame(frame);
}
- DVLOG(1) << ENDPOINT << "Blocked frame received for stream: "
- << frame.stream_id;
+ DVLOG(1) << ENDPOINT
+ << "BLOCKED_FRAME received for stream: " << frame.stream_id;
if (FLAGS_quic_process_frames_inline) {
visitor_->OnBlockedFrame(frame);
should_last_packet_instigate_acks_ = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698