content/browser/cache_storage/cache_storage_cache_unittest.cc - Issue 1304363013: Add a size estimation mechanism to StoragePartitionHttpCacheDataRemover.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cache_storage/cache_storage_cache_unittest.cc

Issue 1304363013: Add a size estimation mechanism to StoragePartitionHttpCacheDataRemover. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missing subclasses. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browsing_data/storage_partition_http_cache_data_remover.cc ('k') | net/base/upload_disk_cache_entry_element_reader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/cache_storage/cache_storage_cache_unittest.cc

diff --git a/content/browser/cache_storage/cache_storage_cache_unittest.cc b/content/browser/cache_storage/cache_storage_cache_unittest.cc

index 88363a7c4d910dc55512b8ad02fd2a51723b6de4..ff0860de1bfe7105302a71df1d8b0a8e8e8b10b9 100644

--- a/content/browser/cache_storage/cache_storage_cache_unittest.cc

+++ b/content/browser/cache_storage/cache_storage_cache_unittest.cc

@@ -91,6 +91,12 @@ class DelayableBackend : public disk_cache::Backend {

const CompletionCallback& callback) override {

return backend_->DoomEntriesSince(initial_time, callback);

}

+ int CalculateSizeOfEntriesBetween(

+ base::Time initial_time,

+ base::Time end_time,

+ const CompletionCallback& callback) override {

+ return backend_->DoomEntriesSince(initial_time, end_time, callback);

jkarlin 2015/09/03 11:05:53 Hmm, DoomEntriesSince doesn't seem right. Perhaps:

msramek 2015/09/03 11:22:22 We can just propagate the call to |backend_|. I no

+ }

scoped_ptr<Iterator> CreateIterator() override {

return backend_->CreateIterator();

}