Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1304363011: Add "Dotum" to the noSubpixelForSmallSizeFont black list (Closed)

Created:
5 years, 3 months ago by kojii
Modified:
5 years, 3 months ago
Reviewers:
drott, eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis, bungeman-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add "Dotum" to the noSubpixelForSmallSizeFont black list This patch disables kSubpixelPositioning_Flag for "Dotum" in small sizes. The embedded bitmap of "Dotum" font looks poorly positioned when linear metrics is used. This patch improves the positioning of the font by disabling linear metrics. Skia disables linear metrics and use DWRITE_MEASURING_MODE_GDI_CLASSIC when kEmbeddedBitmapText_Flag & the font has 'eblc' OpenType table for the specified size & !kSubpixelPositioning_Flag. The first two conditions are already true, this patch turns the last condition to true. BUG=394585 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201515

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
kojii
PTAL. Please also refer to http://crbug.com/394585#c46 for further details.
5 years, 3 months ago (2015-08-30 14:01:49 UTC) #2
eae
https://codereview.chromium.org/1304363011/diff/1/Source/platform/fonts/win/FontCacheSkiaWin.cpp File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right): https://codereview.chromium.org/1304363011/diff/1/Source/platform/fonts/win/FontCacheSkiaWin.cpp#newcode406 Source/platform/fonts/win/FontCacheSkiaWin.cpp:406: L"dotum", You might want to remove it from the ...
5 years, 3 months ago (2015-08-31 17:39:01 UTC) #3
eae
LGTM
5 years, 3 months ago (2015-08-31 17:39:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304363011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304363011/1
5 years, 3 months ago (2015-09-01 00:57:03 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 02:25:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201515

Powered by Google App Engine
This is Rietveld 408576698