Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1304353003: Use EditingStrategy as template parameter to lastEditablePositionBeforePositionInRootAlgorithm templ (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use EditingStrategy as template parameter to lastEditablePositionBeforePositionInRootAlgorithm template function This patch changes template parameter of |lastEditablePositionBeforePositionInRootAlgorithm()| to |EditingStrategy| or |EditingInComposedTreeStrategy| instead of |Position| or |PositionInComposedTre| to match other implementation of editing template functions for improving readability. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201213

Patch Set 1 : 2015-08-26T16:07:59 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/core/editing/EditingUtilities.cpp View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
yoichio
lgtm
5 years, 3 months ago (2015-08-26 07:26:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304353003/1
5 years, 3 months ago (2015-08-26 07:31:27 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 08:08:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201213

Powered by Google App Engine
This is Rietveld 408576698