Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 130433003: Extend silk benchmark of navigation drawer (Closed)

Created:
6 years, 11 months ago by abarth-chromium
Modified:
6 years, 11 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Extend silk benchmark of navigation drawer This CL adds a second test case for inbox_app's navigation drawer that toggles the drawer open and closed using the toolbar button. R=nduca@chromium.org BUG=332439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M tools/perf/page_sets/key_silk_cases.json View 1 chunk +19 lines, -1 line 0 comments Download
M tools/perf/page_sets/key_silk_cases/inbox_app.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
6 years, 11 months ago (2014-01-09 01:52:33 UTC) #1
nduca
lgtm with previous caveats about using wait_after... hasn't that landed by now?
6 years, 11 months ago (2014-01-09 17:37:47 UTC) #2
abarth-chromium
On 2014/01/09 17:37:47, nduca wrote: > lgtm with previous caveats about using wait_after... hasn't that ...
6 years, 11 months ago (2014-01-09 17:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/130433003/1
6 years, 11 months ago (2014-01-09 17:49:36 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 19:41:45 UTC) #5
Message was sent while issue was closed.
Change committed as 243956

Powered by Google App Engine
This is Rietveld 408576698