content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm - Issue 1304303002: Mac Overlays: Add sandwich strategy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm

Issue 1304303002: Mac Overlays: Add sandwich strategy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@overlay_debug

Patch Set: incorporate review feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h ('k') | content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm

diff --git a/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm b/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm

index e008c90961e7047e9436b4b29ff835c2c6d2cdfa..d06b7ce3ba520dc4ba60021dbded54d116690e70 100644

--- a/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm

+++ b/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm

@@ -4,6 +4,8 @@

#include "content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h"

+#include "cc/output/overlay_strategy_sandwich.h"

namespace content {

BrowserCompositorOverlayCandidateValidatorMac::

@@ -17,6 +19,12 @@ BrowserCompositorOverlayCandidateValidatorMac::

~BrowserCompositorOverlayCandidateValidatorMac() {

}

+void BrowserCompositorOverlayCandidateValidatorMac::GetStrategies(

+ cc::OverlayProcessor::StrategyList* strategies) {

+ strategies->push_back(scoped_ptr<cc::OverlayProcessor::Strategy>(

+ new cc::OverlayStrategyCommon(this, new cc::OverlayStrategySandwich)));

void BrowserCompositorOverlayCandidateValidatorMac::CheckOverlaySupport(

cc::OverlayCandidateList* surfaces) {

// SW mirroring copies out of the framebuffer, so we can't remove any