Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: cc/output/overlay_strategy_common.h

Issue 1304303002: Mac Overlays: Add sandwich strategy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@overlay_debug
Patch Set: incorporate review feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_processor.cc ('k') | cc/output/overlay_strategy_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_strategy_common.h
diff --git a/cc/output/overlay_strategy_common.h b/cc/output/overlay_strategy_common.h
index 0291be7c4272f84e4ca021af331a307b7394fa5c..6d8c40559eb6afed356c8430ec9d0c73040fb75b 100644
--- a/cc/output/overlay_strategy_common.h
+++ b/cc/output/overlay_strategy_common.h
@@ -16,22 +16,35 @@ class OverlayCandidateValidator;
class StreamVideoDrawQuad;
class TextureDrawQuad;
+class CC_EXPORT OverlayStrategyCommonDelegate {
+ public:
+ virtual ~OverlayStrategyCommonDelegate() {}
+ virtual bool TryOverlay(OverlayCandidateValidator* capability_checker,
+ RenderPassList* render_passes_in_draw_order,
+ OverlayCandidateList* candidate_list,
+ const OverlayCandidate& candidate,
+ QuadList::Iterator iter,
+ float device_scale_factor) = 0;
+};
+
class CC_EXPORT OverlayStrategyCommon : public OverlayProcessor::Strategy {
public:
- explicit OverlayStrategyCommon(OverlayCandidateValidator* capability_checker);
+ explicit OverlayStrategyCommon(OverlayCandidateValidator* capability_checker,
+ OverlayStrategyCommonDelegate* delegate);
~OverlayStrategyCommon() override;
bool Attempt(RenderPassList* render_passes_in_draw_order,
- OverlayCandidateList* candidate_list) override;
+ OverlayCandidateList* candidate_list,
+ float device_scale_factor) override;
+
+ // Returns true if |draw_quad| will not block quads underneath from becoming
+ // an overlay.
+ static bool IsInvisibleQuad(const DrawQuad* draw_quad);
protected:
bool GetCandidateQuadInfo(const DrawQuad& draw_quad,
OverlayCandidate* quad_info);
- // Returns true if |draw_quad| will not block quads underneath from becoming
- // an overlay.
- bool IsInvisibleQuad(const DrawQuad* draw_quad);
-
// Returns true if |draw_quad| is of a known quad type and contains an
// overlayable resource.
bool IsOverlayQuad(const DrawQuad* draw_quad);
@@ -43,14 +56,9 @@ class CC_EXPORT OverlayStrategyCommon : public OverlayProcessor::Strategy {
bool GetIOSurfaceQuadInfo(const IOSurfaceDrawQuad& quad,
OverlayCandidate* quad_info);
- virtual bool TryOverlay(OverlayCandidateValidator* capability_checker,
- RenderPassList* render_passes_in_draw_order,
- OverlayCandidateList* candidate_list,
- const OverlayCandidate& candidate,
- QuadList::Iterator iter) = 0;
-
private:
OverlayCandidateValidator* capability_checker_;
+ scoped_ptr<OverlayStrategyCommonDelegate> delegate_;
DISALLOW_COPY_AND_ASSIGN(OverlayStrategyCommon);
};
« no previous file with comments | « cc/output/overlay_processor.cc ('k') | cc/output/overlay_strategy_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698