Issue 1304263010: (Merge to M46) Fix crash with null ServiceWorkerProviderHost in DidDispatchFetchEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1304263010: (Merge to M46) Fix crash with null ServiceWorkerProviderHost in DidDispatchFetchEvent (Closed)

Created:
5 years, 3 months ago by falken

Modified:
5 years, 3 months ago

Reviewers:
horo

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

More Reviews

Description

(Merge to M46) Fix crash with null ServiceWorkerProviderHost in DidDispatchFetchEvent The provider host is a WeakPtr and can be destroyed if the tab was closed. BUG=520857 Review URL: https://codereview.chromium.org/1304033004 Cr-Commit-Position: refs/heads/master@{#345568} (cherry picked from commit a6c778d2a0525c8891d4f6fbd8cee0b08f087f1b) TBR=horo Committed: https://chromium.googlesource.com/chromium/src/+/8b1e8e4e3fb7ba22ce51a72f22f103f776b72666

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -22 lines)			Patch
	M	content/browser/service_worker/service_worker_url_request_job.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	content/browser/service_worker/service_worker_url_request_job_unittest.cc	View		8 chunks	+36 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

falken

5 years, 3 months ago (2015-08-31 05:46:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b1e8e4e3fb7ba22ce51a72f22f103f776b72666 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages