Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1304233004: Stop building FilePathWatcher on iOS. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop building FilePathWatcher on iOS. Stop using FilePathWatcher on iOS as it does not works on iOS devices as can be seen when running the unit tests that never finish as no events are reported. Remove the only usage of FilePathWatcher that was present on iOS. This does not change the behaviour since previously even in case of changes to /etc/hosts, the watcher was never informed of any changes. Moreover the file is not editable by the user and so the file will only change after OS upgrade (which requires an app restart) or due to a list of static hosts send as part of dynamic IP negociation (i.e. after a local IP change). BUG=477102 Committed: https://crrev.com/d8143e7373719ed53b6cef35c234b0498b771d48 Cr-Commit-Position: refs/heads/master@{#348400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M base/BUILD.gn View 2 chunks +7 lines, -4 lines 0 comments Download
M base/base.gyp View 2 chunks +4 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -3 lines 0 comments Download
M net/dns/dns_config_service_posix.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
rvargas: can you please take a look?
5 years, 3 months ago (2015-09-10 10:14:15 UTC) #2
rvargas (doing something else)
lgtm
5 years, 3 months ago (2015-09-10 19:07:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304233004/1
5 years, 3 months ago (2015-09-11 13:06:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 15:16:22 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d8143e7373719ed53b6cef35c234b0498b771d48 Cr-Commit-Position: refs/heads/master@{#348400}
5 years, 3 months ago (2015-09-11 15:17:51 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:22:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8143e7373719ed53b6cef35c234b0498b771d48
Cr-Commit-Position: refs/heads/master@{#348400}

Powered by Google App Engine
This is Rietveld 408576698