Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1304213003: Compositor Animations: Do not create compositor animation timeline for remote frames (Closed)

Created:
5 years, 3 months ago by loyso (OOO)
Modified:
5 years, 3 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Compositor Animations: Do not create compositor animation timeline for remote frames We create ScrollingCoordinator for pages with non-local frames, but it's noop in functionality because of guards: if (!m_page->mainFrame()->isLocalFrame()) return; Let's align the behavior with the rest of ScrollingCoordinator code. Otherwise it crashes browser tests. BUG=394777 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
loyso (OOO)
5 years, 3 months ago (2015-09-08 07:08:37 UTC) #2
Ian Vollick
lgtm
5 years, 3 months ago (2015-09-09 00:40:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304213003/1
5 years, 3 months ago (2015-09-09 00:40:46 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 02:00:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201945

Powered by Google App Engine
This is Rietveld 408576698