src/objects.cc - Issue 13042013: ES6 symbols: symbol properties should not cause going into slow mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 13042013: ES6 symbols: symbol properties should not cause going into slow mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix assertion. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 9d6c055c1b33c908c582e1ce193d1e52e2c63803..03cb5ce91c7dbbfb1331a26e28b95a5cba946d26 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1733,7 +1733,7 @@ MaybeObject* JSObject::AddFastProperty(Name* name,

// hidden strings) and is not a real identifier.

// Normalize the object if it will have too many fast properties.

Isolate* isolate = GetHeap()->isolate();

- if ((!IsIdentifier(isolate->unicode_cache(), name)

+ if ((!name->IsSymbol() && !IsIdentifier(isolate->unicode_cache(), name)

&& name != isolate->heap()->hidden_string()) ||

(map()->unused_property_fields() == 0 &&

TooManyFastProperties(properties()->length(), store_mode))) {

« no previous file with comments | « no previous file | test/mjsunit/harmony/symbols.js » ('j') | no next file with comments »