Issue 13042013: ES6 symbols: symbol properties should not cause going into slow mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13042013: ES6 symbols: symbol properties should not cause going into slow mode. (Closed)

Created:
7 years, 9 months ago by rossberg

Modified:
7 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev, adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ES6 symbols: symbol properties should not cause going into slow mode. R=yangguo@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14089

Patch Set 1 #

Patch Set 2 : Fix assertion. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/mjsunit/harmony/symbols.js	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

On 2013/03/27 17:55:11, Yang wrote: > On 2013/03/27 17:51:58, rossberg wrote: > > lgtm。 Actually, ...

7 years, 9 months ago (2013-03-27 18:45:29 UTC) #3

rossberg

7 years, 9 months ago (2013-03-28 11:53:46 UTC) #4

On 2013/03/27 18:45:29, rossberg wrote:
> On 2013/03/27 17:55:11, Yang wrote:
> > On 2013/03/27 17:51:58, rossberg wrote:
> > 
> > lgtm。
> 
> Actually, not good at all, considering that calling %HasFastProperties does
not
> mean much without an an 'assertTrue' around it -- and it actually fails when I
> add that. 8-}

Makes more sense now.

Expand Messages | Collapse Messages