Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304183006: Fail preflight request when redirect is received (Closed)

Created:
5 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 3 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fail preflight request when redirect is received BUG=510650, 525479 R=japhet Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201547

Patch Set 1 #

Patch Set 2 : Fixed order #

Patch Set 3 : Add layout tests #

Patch Set 4 : #

Patch Set 5 : Updated expectation #

Total comments: 2

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M LayoutTests/http/tests/fetch/script-tests/fetch.js View 1 2 3 2 chunks +23 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
tyoshino (SeeGerritForStatus)
5 years, 3 months ago (2015-08-27 12:25:57 UTC) #2
tyoshino (SeeGerritForStatus)
One layouttest expectation had to be updated. Fixed in ps5.
5 years, 3 months ago (2015-08-28 04:35:07 UTC) #3
Nate Chapin
lgtm https://codereview.chromium.org/1304183006/diff/80001/Source/core/loader/DocumentThreadableLoader.cpp File Source/core/loader/DocumentThreadableLoader.cpp (right): https://codereview.chromium.org/1304183006/diff/80001/Source/core/loader/DocumentThreadableLoader.cpp#newcode321 Source/core/loader/DocumentThreadableLoader.cpp:321: request = ResourceRequest(); Is this line still necessary? ...
5 years, 3 months ago (2015-08-31 20:05:26 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/1304183006/diff/80001/Source/core/loader/DocumentThreadableLoader.cpp File Source/core/loader/DocumentThreadableLoader.cpp (right): https://codereview.chromium.org/1304183006/diff/80001/Source/core/loader/DocumentThreadableLoader.cpp#newcode321 Source/core/loader/DocumentThreadableLoader.cpp:321: request = ResourceRequest(); On 2015/08/31 20:05:26, Nate Chapin wrote: ...
5 years, 3 months ago (2015-09-01 08:05:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304183006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304183006/100001
5 years, 3 months ago (2015-09-01 08:07:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/128823)
5 years, 3 months ago (2015-09-01 08:57:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304183006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304183006/100001
5 years, 3 months ago (2015-09-01 09:33:34 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 10:43:54 UTC) #13
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201547

Powered by Google App Engine
This is Rietveld 408576698